Skip to content

Updates from other forks#1

Closed
BatmanAoD wants to merge 34 commits intomasterfrom
main
Closed

Updates from other forks#1
BatmanAoD wants to merge 34 commits intomasterfrom
main

Conversation

@BatmanAoD
Copy link
Copy Markdown
Collaborator

See upstream_commit_recommendations.txt, written by Claude Haiku 4.5. Claude then created a merge request with the described commit chain and manual changes.

I selected the name rigetti-hyper-proxy for the crate.

The final commit, "do a few more dependency updates," is from simply running cargo upgrade -i. (The "upgrade" command comes from cargo-edit.)

Rather than merging this, we should simply switch the default branch to main once we're satisfied that this looks correct.

@BatmanAoD
Copy link
Copy Markdown
Collaborator Author

We should also delete this fork: https://github.com/rigetti/hyper-proxy2

override: true
- uses: katyo/publish-crates@v2
with:
registry-token: ${{ secrets.CRATES_IO_SECRET }} No newline at end of file
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator

@jselig-rigetti jselig-rigetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once tests are passing, this looks reasonable

Comment thread Cargo.toml Outdated
Comment thread Cargo.toml Outdated
Comment thread README.md
Comment thread LICENSE-MIT.md
Comment thread src/stream.rs
@jselig-rigetti
Copy link
Copy Markdown
Collaborator

We should also delete this fork: https://github.com/rigetti/hyper-proxy2

@BatmanAoD Ok, I've archived it

@rigetti rigetti deleted a comment from BatmanAoD Apr 17, 2026
Comment thread LICENSE-MIT.md
@BatmanAoD
Copy link
Copy Markdown
Collaborator Author

I'm going to delete the LLM-generated recommendations file. Here are the contents, for posterity.


Here's my assessment of all commits in main.., grouped by fork:


hyper-http-proxy fork

Commit Message Recommendation
tlnmuprv update dependencies (tokio-rustls 0.25→0.26, hyper-rustls 0.26→0.27) KEEP — but superseded by later commits; only needed if taking partial chain
xlwskxwp Refactor (new feature naming, drop openssl, rename webpki→rustls-webpki) KEEP — major structural improvement; drops openssl-tls support (intentional in this fork)
lotvxkwy rename to hyper-http-proxy (package name + 1.0.0) KEEP with modification — take the Cargo.toml/README/LICENSE changes, but you'll want to decide on your own version numbering and crate name
okyzxmwl hygiene (remove rustls-tls/rustls-tls-manual-roots aliases, update README) KEEP
rpvqwonu lint (fix CI --features flags, add CustomProxyCallback type alias, minor lints) KEEP
xlmqyxqu release (add release.yaml CI workflow) DISCARD — MetalBear's CI setup, not yours
pmxowuno fix test (remove rustls-tls-manual-roots from CI since feature was removed) KEEP
rvlmmzus .. (1.0.0 tag; likely just Cargo.lock update) DISCARD — noise commit
tzpxxmtk call set_authorization when creating a Proxy (auto-extract credentials from URI) KEEP — useful feature with tests
qsxzsozm Update lib.rs (refactor extract_user_pass: rsplit_once, avoid allocation) KEEP
pspprnvv add doc (docstring for extract_user_pass) KEEP
ztllkrlr cargo fmt --all KEEP
spnpoosu 1.1.0 version bump KEEP (re-version as appropriate)
ozuxnknk remove unused rustls-native-certs direct dep (let hyper-rustls handle it) KEEP
uqkvyvqt Bump 1.1.0→1.1.1, fix missing trailing newline in Cargo.toml KEEP (re-version as appropriate)

hyper-proxy2 fork

Commit Message Recommendation
ovssllkp feat: Upgrade to http/hyper 1.0 DISCARD — foundation for both forks; hyper-http-proxy's chain is a superset of this work
mvrkoylw ci: Add GitHub Actions workflow DISCARD — superseded by hyper-http-proxy's CI (which has better feature matrix)
vmzzswov fix: Use from_proxy_unsecured in examples for no-tls/native-tls DISCARD — the example and feature names changed in hyper-http-proxy refactor
zxrptwwl chore: Fix doc URL, bump MSRV to 1.70 DISCARD — doc URL is for siketyan's fork; MSRV bump is worth keeping conceptually but re-apply manually
qupmtylz ci: Remove Travis CI DISCARD — already absent in hyper-http-proxy chain
qrqymtru Do not crash if path is missing (.unwrap().ok_or_else()) KEEP — genuine bug fix not present in hyper-http-proxy chain; should be cherry-picked
rsrxxons Bump tokio-rustls 0.25→0.26, hyper-rustls 0.26→0.27, webpki-roots 0.26→1.0.3 DISCARD — tokio-rustls/hyper-rustls bump is in hyper-http-proxy chain; webpki-roots bump to 1.0.3 may conflict with hyper-http-proxy's 0.26

Summary: Take the full hyper-http-proxy chain (minus xlmqyxqu release.yaml and rvlmmzus noise), plus cherry-pick qrqymtru from hyper-proxy2 for the panic fix. The hyper-proxy2 branch is otherwise entirely superseded.

One thing to decide before you start: do you want to keep the crate name as hyper-proxy or adopt hyper-http-proxy? That affects how you handle lotvxkwy.

@BatmanAoD
Copy link
Copy Markdown
Collaborator Author

Closing now that main is the default branch.

@BatmanAoD BatmanAoD deleted the branch master April 20, 2026 21:41
@BatmanAoD BatmanAoD closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants